MAYA-111521: Fix error messages showing up when opening the "Applied Schema" category #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Schema" category.
|
It looks simple and safe, but there is one thing I don't know. @seando-adsk Is it expected to have attributes with empty names? How are they created? |
|
No it is not expected to have empty attribute names, but there is no harm in protecting against a bad caller passing in an empty string. That is what happens in this case from some bad code in Maya that is trying to optimize boolean attributes onto a single line. |
kxl-adsk
approved these changes
May 27, 2021
HamedSabri-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Accessing certain AE tabs (e.g Applied Schema, Cylinder Light ) results in "propName.IsEmpty()" error to spit out by USD. We currently allow creating attributes with an empty strings which are not accepted by USD. This doesn't only happen when accessing "Applied Schema" tabs but also in other attribute tabs "Cylinder Light".
In USD land At Line 523 , the property name can't be empty. Hence the error reported.
https://github.com/PixarAnimationStudios/USD/blob/090ef0d849ced875b3b99a15e454b69148ccd8e1/pxr/usd/usd/stage.cpp#L4523