MAYA-111691 cards draw mode #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
commented
Jun 4, 2021
| stReader.parameters[_tokens->varname] = _tokens->cardsUv; | ||
| outNet.nodes.push_back(stReader); | ||
| stPrimvarReader = &outNet.nodes.back(); | ||
| outNet.primvars.push_back(_tokens->cardsUv); |
There was a problem hiding this comment.
This is only correct for the cards draw mode shader. I will have to think of a way to make this safe.
williamkrick
commented
Jun 4, 2021
| if (bufferData) { | ||
| const VtIntArray& primvarData = value.UncheckedGet<VtIntArray>(); | ||
|
|
||
| VtFloatArray convertedPrimvarData; |
There was a problem hiding this comment.
We need this because we can't properly create vertex buffers for integer types.
| (UsdPrimvarReader_color) | ||
| (UsdPrimvarReader_vector) | ||
| ); | ||
| // clang-format on | ||
|
|
||
| TfToken _DrawModeCards | ||
| = TfToken("drawMode.glslfx"); //!< can't make a token the normal way because it has a '.' in it. |
There was a problem hiding this comment.
There is a syntax for that in the tokens. You need to use:
((drawMode, "drawMode.glslfx"))
// To use it:
_tokens->drawMode
| @@ -837,6 +863,15 @@ void HdVP2Material::_ApplyVP2Fixes(HdMaterialNetwork& outNet, const HdMaterialNe | |||
| tmpNet.nodes.reserve(numNodes); | |||
| tmpNet.relationships.reserve(numRelationships); | |||
|
|
|||
| // Some material networks require us to nodes and connections to the base | |||
There was a problem hiding this comment.
There is a verb missing in that sentence.
JGamache-autodesk
approved these changes
Jun 7, 2021
JGamache-autodesk
approved these changes
Jun 8, 2021
… cube shades differently.
|
This should be ready to merge tomorrow once the preflight issues get resolved. |
williamkrick
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to Vp2RenderDelegate for the "cards" drawing mode.
Issue #1382.
I'll add a test using either the file from the issue or I'll create some programmer art.