[al] make pushToPrim default to On #149
Conversation
...a recent AL change (55e01cf) added the ability to control the setting for pushToPrim for newly created nodes via an optionVar, which is useful, but it also changed the default from on to off. In addition to being breaking behavior, this is also highly non-intuitive for artists, who will be confused when they try to transform the usd object, and it does nothing. I would also argue that the ability to pushToPrim is the primary thing which distinguishes this plugin from the Pixar plugin, and as such, is probably why most people are using it in the first place.
|
@elrond79 - This also initially tripped us up ( and readAnimatedAttributes ). We resorted to setting the default optionVar ourselves to work-around the issue. If we're going for this one, why not the other? |
|
Hmm, good point - I guess I wasn't aware the default for that had changed as well. And yeah, for now we're also setting the default ourselves. Just think it might trip up newcomers. |
|
Based on the conversation, it's unclear to me whether or not there is still something to do in this PR? To be precise, should Also, I see @robthebloke reviewed it. Do we need anyone else to approve it? (@murphyeoin) |
|
Yeah, I guess it's a little unclear to me too. I guess I was hoping AL would chime in on the topic. @robthebloke or @murphyeoin - thoughts on also setting readAnimatedValues default to true? I guess the default for this changed slightly further back - in 97d3ff3. (And for my vote, I don't think we need both Rob and Eoin to review... I just added them both hoping one would respond.) |
…iles added comment options when copying files
|
I decided to make readAnimatedValues it's own PR, since I could potentially see AL objecting to that, but not to this. |
|
Oops, forgot to link it: #226 |
|
OK. Just double-checking - @murphyeoin you are good to make this change? |
|
Thanks! |
…-issue-VP2 PIPE-3073 - fix instance proxy issue vp2
...a recent AL change (55e01cf) added
the ability to control the setting for pushToPrim for newly created
nodes via an optionVar, which is useful, but it also changed the default
from on to off.
In addition to being breaking behavior, this is also highly
non-intuitive for artists, who will be confused when they try to
transform the usd object, and it does nothing. I would also argue that
the ability to pushToPrim is the primary thing which distinguishes this
plugin from the Pixar plugin, and as such, is probably why most people
are using it in the first place.
NOTE: I haven't yet run the tests for this, as the tests are still not fully functional on the dev branch. Assuming we agree that this change should be made, we may wish to delay merging it in until the tests work, at which time we can ensure that this modification doesn't require making changes to any tests.