MAYA-107463 Make sure we leave default material mode when the test ends. Check fo… #1552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r UFE version correctly.
williamkrick
commented
Jul 6, 2021
lib/mayaUsd/CMakeLists.txt
Outdated
| @@ -69,7 +69,7 @@ if (MAYA_API_VERSION VERSION_GREATER_EQUAL 20220100 AND MAYA_API_VERSION VERSION | |||
| ) | |||
| endif() | |||
|
|
|||
| if (MAYA_API_VERSION VERSION_GREATER_EQUAL 20230000 AND UFE_VERSION VERSION_GREATER_EQUAL 2.0.3) | |||
| if (MAYA_API_VERSION VERSION_GREATER_EQUAL 20230000 AND UFE_VERSION VERSION_GREATER_EQUAL 0.3.0) | |||
There was a problem hiding this comment.
Building with master I discovered this expression was wrong.
williamkrick
commented
Jul 6, 2021
| def tearDownClass(cls): | ||
| panel = mayaUtils.activeModelPanel() | ||
| cmds.modelEditor(panel, edit=True, useDefaultMaterial=False) | ||
|
|
There was a problem hiding this comment.
If testInstanceDefaultMaterial fails the image test while useDefaultMaterial is enabled the rest of the script doesn't run to turn it off. I have to set useDefaultMaterial false in the tearDownClass so other scripts will not have it on, and also at the start of the other test runs within this script to ensure they don't have it on.
JGamache-autodesk
approved these changes
Jul 6, 2021
williamkrick
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r UFE version correctly.
Discovered this while working on MAYA-107463, decided to split out the useful changes because that work is held up.