Pr/allow usd reader registration for tf type tokens #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should also work for C++Types since these get registered with the TfType system. Also update RfM light and lightFilter reading and writing code to use the generic Usd APIs instead of the soon-to-be-removed and "made" codeless UsdRiPxr* APIs
|
@dj-mcg We have some issues with GitHub actions causing PF to time out. For now, we haven't heard back from GitHub regarding ETA. |
|
Ah, ok @kxl-adsk - so no action required on my end then? |
boudrey
approved these changes
Aug 16, 2021
JGamache-autodesk
approved these changes
Aug 16, 2021
|
Hey folks - I have another change I'd like to push & PR that depends on this one. Should it make it part of this same PR or open a new one? |
seando-adsk
added
the
ready-for-merge
|
@dj-mcg Since the review and preflight were already completed I've merged this PR, so if you have another change can you open a new PR for it. |
|
Oh, great, thanks @seando-adsk! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow usdReader function registration for TfType tokens. This should also work for C++Types since these get registered with the TfType system.
Also update RfM light and lightFilter reading and writing code to use the generic Usd APIs instead of the soon-to-be-removed and "made" codeless UsdRiPxr* APIs