Fixes incorrect Schlick Fresnel for IBL lighting #1634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Affects only Light API V2 (requires env var to activate)
JGamache-autodesk
added
materials
vp2renderdelegate
williamkrick
approved these changes
Aug 18, 2021
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For environment mapping, we assume symmetric reflection around the normal, which means the half vector H is actually equal to the normal N. The value of dot(E, H) then becomes equal to the value previously found and used for dot(N, E).
This fixes a highlight artifacts seen when looking at the Damaged Helmet asset from below as shown in this before and after image:
