Add tests for sets command and for isolate select in Vp2RenderDelegate. #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
added
unit test
williamkrick
added
the
do-not-merge-yet
|
I have one additional Maya change that is necessary to prevent the isolate select test from crashing, so do not merge this until that change is available. |
ppt-adsk
requested changes
Sep 3, 2021
| def setUpClass(cls): | ||
| # The test USD data is authored Z-up, so make sure Maya is configured | ||
| # that way too. | ||
| # cmds.upAxis(axis='z') |
test/lib/ufe/testSetsCmd.py
Outdated
Comment on lines
22
to
25
| import ufeUtils | ||
| import usdUtils | ||
|
|
||
| import mayaUsd.ufe |
There was a problem hiding this comment.
Don't think any of these are used.
test/lib/ufe/testSetsCmd.py
Outdated
Comment on lines
32
to
34
| import ufe | ||
|
|
||
| import os |
williamkrick
force-pushed
the
krickw/MAYA-113057/isolate_select_regression_tests
branch
from
2147b3e to
a231d29
Compare
ppt-adsk
requested changes
Sep 13, 2021
| cmds.sets( usdCube, add=set1 ) # Add Cube1 to set1 | ||
| self.assertTrue(cmds.sets( usdCube, im=set1 )) # Test if Cube1 is in set1 | ||
|
|
||
| # Undo, Redo |
There was a problem hiding this comment.
Looks like redo() never actually made it into the file :)
ppt-adsk
approved these changes
Sep 20, 2021
williamkrick
removed
the
do-not-merge-yet
JGamache-autodesk
approved these changes
Sep 21, 2021
|
|
||
| # Turn on isolate select for cube | ||
| cmds.select(usdCube) | ||
| cmds.isolateSelect("modelPanel4", state=1) |
There was a problem hiding this comment.
Can this function use the result of mayaUtils.activeModelPanel() as first parameter? Would it make the test more robust?
williamkrick
added
the
ready-for-merge
kxl-adsk
deleted the
krickw/MAYA-113057/isolate_select_regression_tests
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.