Update refactoring sandbox #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HamedSabri-adsk
commented
Aug 15, 2019
HamedSabri-adsk
commented
- mayaUsd translator import / export MEL scripts.
- Reference assembly cleanup ( Factored out scene assembly from base readJob class )
- Run time path improvement for MacOSX and Linux
- Fix variant switching after merge of proxy shapes
- Fix import (Import works in ADSK and PXR plugins, AL translator now loads and imports)
- Fix for building in debug
- Added top-level cmake option "CMAKE_WANT_UFE_BUILD" with default value ON. When enabled, we (quietly) try to find UFE and if available we enable it and use it for building. If not available, then don't compile UFE features.
- Linux translator plugins: Compilation and hdMaya camelCase fixes, mayaUsd_Translators and mayaUsd_Schemas Pixar PlugPlugin's load
- Complete selection highlight support for VP2RenderDelegate
- Fix build errors with Maya 2018
- Added new flags to have better control over Cmake stages in the build script.
- Fix windows build. Missing exports
Fix typo in README!
* MAYA-99741 - Build all 3 plugins build/work in sandbox * Override postConstructor in Maya & Pixar proxy shape and call the base class. * Remove from the base class: PxrMayaHdImagingShape::GetOrCreateInstance(); * From all three plugins (Maya/Pixar/AL) call the base class and in Maya/Pixar (not AL) put the call to GetOrCreateInstance and conditionally call it using MayaUsdProxyShapePlugin::useVP2_NativeUSD_Rendering() * MAYA-99741 - Build all 3 plugins build/work in sandbox * Oops, fixed mistake in logic.
* Add back the jinja.cmake file, which is only used when building inside the Maya build. * Make sure the build and install folders have the variant.
…#83) * MAYA-99646 Fix selection highlight issues * Selection highlight for proxy selection from Outliner. * Selection highlight for Xform prims from Outliner. * Selection highlight for USD instancing objects. * MAYA-99646 capitalize function name * MAYA-99646 Differentiate the processing for "wasProxySelected" and "isProxySelected" case.
* Make sure the build and install folders have the variant (#2) * Enable generating compile_commands.json by default * Make sure the build and install folders have the variant * Fix typo in ReadMe * temporarily revert line endings to windows to do merge * standardize on linux-style line endings (newline only) (cherry picked from commit 8073eaf)
* mayaUsd_Translators and mayaUsd_Schemas Pixar PlugPlugin's load. * Removed translator plugin requirement for sidecar Maya plugin. * Compilation and hdMaya camelCase fixes. * Addressed code review feedback.
Build with Maya 2018 has passed on Windows. Smoke test looks fine.
(cherry picked from commit 8b3b348)
… commit." This reverts commit 3b79e1b.
* Linux (gcc) and Mac (clang) fixes.
* MAYA-99741 - Build all 3 plugins build/work in sandbox * Added top-level cmake option "CMAKE_WANT_UFE_BUILD" with default value ON. When enabled, we (quietly) try to find UFE and if available we enable it and use it for building. If not available, then don't compile UFE features. * Being an option means users UFE can be disabled if needed. * Removed logic which looked for UFE only when devkit location was set. * Replaced specialized "HDMAYA_UFE_BUILD" define with our generic "WANT_UFE_BUILD" define. * Replaced xxx_INT vars with cmake configure logic. * Added missing UFE to pxrUsd plugin. * MAYA-99741 - Build all 3 plugins build/work in sandbox * No need for extra #define in the promoted header file hdMaya.h. Just use the standard cmake add_definitions which works on all platforms and is consistent with the rest of our repo.
* - trying to be explicit here for sake of clarity! * - Fix MacOSX python issue that was caused by overriding args. Thanks to Pierre! (cherry picked from commit cc2ca87)
(cherry picked from commit 09d835f)
* Fix for building in debug.
* Fixed pxrUsd RPATH, and removed incorrect linking to mayaUsd_Schemas plugin. * Import works in ADSK and PXR plugins. * AL translator now loads and imports. * Addressed review comments.
* Brought over Pixar's runtime path routines into cmake/utils module and started using them in the project * Fixed MacOSX build * Added IS_WINDOWS, IS_LINUX, IS_MACOSX variables to determine the OS type
* Factored out scene assembly from base readJob class. * Factored code to remove REFACTOR_PROXY_SHAPE. * Factored reference assembly out of instancerImager. * Factored reference assembly out of instancerShapeAdapter. * Enabled used of derived instancer shape adapter factory.
* mayaUsd translator import / export MEL scripts. * Addressed code review feedback.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.