MAYA-113077: componentTag IO to files #1755
Conversation
|
@rijpkeh I don't know enough about component tags to write unit tests that would read and write them. Could you provide an example of a Python script that would exercise this code so that I could write a unit test in the MayaUSD project? |
ppt-adsk
added
the
do-not-merge-yet
- Add exportComponentTags export option in the command and UI. - Removed useless call to base file translator writer. - Added a unit test that verifies comonent tags survive USD export / import.
| @@ -1369,4 +1372,53 @@ bool UsdMayaMeshWriteUtils::getMeshColorSetData( | |||
| return true; | |||
| } | |||
|
|
|||
| MStatus UsdMayaMeshWriteUtils::exportComponentTags(UsdGeomMesh& primSchema, MObject obj) | |||
There was a problem hiding this comment.
Why to even make this method available for older versions of Maya?
There was a problem hiding this comment.
I wanted to change Hans code as little as possible, but I can move the #ifdef out and #ifdef atthe caller site too instead of having a do-nothing function in older versions of Maya.
| TfToken componentTagFamilyName("componentTag"); | ||
| MFnGeometryData fnGeomData(geomObj); | ||
| MStringArray keys; | ||
| status = fnGeomData.componentTags(keys); |
There was a problem hiding this comment.
This status doesn't seem to be checked.
There was a problem hiding this comment.
Yes, and it is not the only one, there are others a bit below. In all cases, the code seems to rely on the returned data (for example the set of keys) to be empty. Of course, that could cause silent failures. I'll add more early returns.
| @@ -882,4 +885,71 @@ MStatus UsdMayaMeshReadUtils::assignSubDivTagsToMesh( | |||
| return MS::kSuccess; | |||
| } | |||
|
|
|||
| MStatus UsdMayaMeshReadUtils::createComponentTags(const UsdGeomMesh& mesh, const MObject& meshObj) | |||
There was a problem hiding this comment.
Why to make this method available in older versions of Maya?
| @@ -226,6 +226,7 @@ global proc int mayaUsdTranslatorExport (string $parent, | |||
| string $eulerFilterAnn = "Exports the euler angle filtering that was performed in Maya."; | |||
| string $staticSingleSampleAnn = "Converts animated values with a single time sample to be static instead."; | |||
| string $visibilityAnn = "Exports Maya visibility attributes as USD metadata."; | |||
| string $componentTagsAnn = "Exports Maya component tags as USD metadata."; | |||
There was a problem hiding this comment.
Did you run this by design? FWIW. We are writing out component tags as UsdGeomSubset, not as metadata.
There was a problem hiding this comment.
No, you're right I did not ask design.
There was a problem hiding this comment.
Removed the new UI.
- Move ifdef for Maya 2022 outdide of the affected functions and their callers. - Remove the export component tag UI that was added with designer input.
pierrebai-adsk
added
ready-for-merge
Code for component tag support on behalf of Hans Rijpmeka.