Updated LayerManager to purge cached self on scene reset #1760
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kxl-adsk
added
adsk
kxl-adsk
suggested changes
Oct 19, 2021
lib/mayaUsd/nodes/layerManager.cpp
Outdated
| if (layerManagerHandle.isValid() && layerManagerHandle.isAlive()) { | ||
| MObject mobj { layerManagerHandle.object() }; | ||
| if (!mobj.isNull()) { | ||
| fn.setObject(mobj); | ||
| return static_cast<MayaUsd::LayerManager*>(fn.userNode()); | ||
| } else { | ||
| MGlobal::displayInfo("LayerManager::findNode cache got null MObject"); |
There was a problem hiding this comment.
These traces doesn't tell much to the end-user, please remove them.
|
Here's the stack we got with that issue: |
fabal
force-pushed
the
J-Mo63/register-scene-reset-notice
branch
from
92f5c27
to
70cbf10
Compare
kxl-adsk
approved these changes
Oct 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change to the AL plugin's
LayerManagerwas authored to solve a multi-threaded-related crash when using a somehow "valid" and "alive"MObjectHandlefor theLayerManagercache. The change ensures that the cache is cleared on each new scene, resolving the issue.I have also gone ahead and made similar changes to the shared
LayerManageras requested in PR #1734. Let me know if there are any changes you think would be appropriate for the shared implementation - I've tried to base it on what was already there.