Make sure test runner does not import itself #1795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By giving it a different name from the module under test.
seando-adsk
reviewed
Oct 29, 2021
| @@ -170,7 +170,7 @@ finally: | |||
| ) | |||
| endif() | |||
|
|
|||
| set(SCRIPT ${CMAKE_BINARY_DIR}/test/Temporary/scripts/${test_name}.py) | |||
| set(SCRIPT ${CMAKE_BINARY_DIR}/test/Temporary/scripts/runner_${test_name}.py) | |||
There was a problem hiding this comment.
@boudrey Should we also make this fix on line 149?
There was a problem hiding this comment.
That would be a good idea to keep it similar.
There was a problem hiding this comment.
@JGamache-autodesk Can you please fix line 149 as well. Thanks.
There was a problem hiding this comment.
This will have no effect because there is no module import in that branch. I can do it for the sake of keeping these two paths similar.
seando-adsk
approved these changes
Oct 29, 2021
boudrey
approved these changes
Oct 29, 2021
JGamache-autodesk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By giving it a different name from the module under test.