Made all dirty layers and anonymous sublayers serialisable #1872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabal
force-pushed
the
J-Mo63/serialisable-anonymous-layers
branch
from
eb46724
to
c3d2348
Compare
Co-authored-by: Josh Henare <joshhe@zero.al.com.au>
fabal
force-pushed
the
J-Mo63/serialisable-anonymous-layers
branch
from
c3d2348
to
8bc36df
Compare
kxl-adsk
approved these changes
Dec 7, 2021
|
Yes. We have something to investigate...it's unclear to me which change caused it 😕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates two changes:
The proxy shape has been updated to make all dirty layers serialisable regardless of whether they have ever been set as an edit target or not when saving Maya scenes. As a result anonymous sublayer content can be serialised.
Loading a scene serialised with anonymous sublayers results in stale references to previous sublayers' IDs. Although they exist in the registry on load, their IDs no longer match those referenced. Support has been added for the serialisation and deserialisation of anonymous sublayers to Maya files by the layer manager.