MAYA-113917 Skip Ufe Identifier update when the identifiers are not in use. #1875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamkrick
added
do-not-merge-yet
perrauo-adsk
previously approved these changes
Dec 3, 2021
JGamache-autodesk
previously approved these changes
Dec 3, 2021
| @@ -46,6 +47,7 @@ | |||
| #include <pxr/usd/usd/prim.h> | |||
| #include <pxr/usdImaging/usdImaging/delegate.h> | |||
|
|
|||
| #include <maya/M3dView.h> | |||
There was a problem hiding this comment.
Minor: Can you remove this include? I did not see it used.
williamkrick
dismissed stale reviews from JGamache-autodesk and perrauo-adsk
via
c7fdeab
JGamache-autodesk
approved these changes
Dec 6, 2021
JGamache-autodesk
added
ready-for-merge
williamkrick
added
ready-for-merge
kxl-adsk
deleted the
krickw/MAYA-113917/update_ufe_identifiers_on_demand
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change mitigates the high performance cost of reading the prim path of instanced objects from USD by only reading the path when it is necessary.