Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed AL_usdmaya_ProxyShapeSelect command and related functionality #2009

Merged
merged 4 commits into from
Jan 27, 2022

Conversation

jonjondev
Copy link
Contributor

In response to the closure of PR #1855 and the flagged changes of discussion item #1879, this PR removes the AL_usdmaya_ProxyShapeSelect command from the AL plugin, which should be handled from this point forwards via UFE selection.

Several tests have been rewritten to accommodate the changes, and a number of custom transform tests previously used the command to build transform chains as test data for convenience. This shift marks version 3 for the AL plugin.

kxl-adsk
kxl-adsk previously approved these changes Jan 21, 2022
@kxl-adsk
Copy link

kxl-adsk commented Jan 25, 2022

@fabal, @J-Mo63 The PF looks to be failing because of two errors (one platform-dependent and one Maya version dependent):

15:48:51     /local/S/jenkins/workspace/ecg-mayausd-branch-preflight-python3-osx/ecg-maya-usd/maya-usd/plugin/al/lib/AL_USDMaya/AL/usdmaya/nodes/ProxyShapeSelection.cpp:45:13: error: unused function 'addObjToSelectionList' [-Werror,-Wunused-function]
15:48:51     inline void addObjToSelectionList(MSelectionList& list, const MObject& object)

and because of

15:45:44     S:\jenkins\workspace\ecg-mayausd-branch-preflight-2019-no-ufe-windows\ecg-maya-usd\maya-usd\plugin\al\plugin\AL_USDMayaTestPlugin\AL\usdmaya\nodes\test_TransformMatrix.cpp(24): fatal error C1083: Cannot open include file: 'mayaUsd/ufe/Utils.h': No such file or directory

both errors are available in logs associated with PF.

@jonjondev
Copy link
Contributor Author

@fabal, @J-Mo63 The PF looks to be failing because of two errors (one platform-dependent and one Maya version dependent):

15:48:51     /local/S/jenkins/workspace/ecg-mayausd-branch-preflight-python3-osx/ecg-maya-usd/maya-usd/plugin/al/lib/AL_USDMaya/AL/usdmaya/nodes/ProxyShapeSelection.cpp:45:13: error: unused function 'addObjToSelectionList' [-Werror,-Wunused-function]
15:48:51     inline void addObjToSelectionList(MSelectionList& list, const MObject& object)

and because of

15:45:44     S:\jenkins\workspace\ecg-mayausd-branch-preflight-2019-no-ufe-windows\ecg-maya-usd\maya-usd\plugin\al\plugin\AL_USDMayaTestPlugin\AL\usdmaya\nodes\test_TransformMatrix.cpp(24): fatal error C1083: Cannot open include file: 'mayaUsd/ufe/Utils.h': No such file or directory

both errors are available in logs associated with PF.

Yup seen that warning and the UFE issue. We have a fix ready for those and hopefully it'll be up soon.

@kxl-adsk kxl-adsk merged commit dd8b48d into Autodesk:dev Jan 27, 2022
@jonjondev jonjondev deleted the J-Mo63/remove-al-proxyshapeselect branch January 27, 2022 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
al Related to AnimalLogic plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants