Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-121303 Setting the instance colors or transforms into Maya is expensive. #2110

Merged

Conversation

williamkrick
Copy link
Contributor

If we discover they haven't changed then don't set the values into Maya.

discover they haven't changed then don't set the values into Maya.
vlasovi
vlasovi previously approved these changes Feb 16, 2022
Copy link
Collaborator

@vlasovi vlasovi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. This will create a couple of conflicts with my refactoring changes so I will need to merge properly those changes with mine.

@williamkrick
Copy link
Contributor Author

The test failure was TestALUSDMayaPython_LayerManager which is unrelated to this change.

@williamkrick williamkrick added vp2renderdelegate Related to VP2RenderDelegate ready-for-merge Development process is finished, PR is ready for merge labels Feb 22, 2022
@seando-adsk seando-adsk merged commit a2be5f6 into dev Feb 22, 2022
@seando-adsk seando-adsk deleted the krickw/MAYA-121303/dont_update_instancing_on_selection_change branch February 22, 2022 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge vp2renderdelegate Related to VP2RenderDelegate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants