[al] Added export option to merge offset parent matrix #2218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
previously approved these changes
Mar 31, 2022
|
Disabled the offsetParentMatrix support for Maya 2019, the unit test should pass fine now. |
ppt-adsk
approved these changes
Apr 4, 2022
|
@csyshing can we ask you to merge in the latest dev into your branch? There was a fix done for interactive Linux tests which was merged, so we'd feel a whole lot better if the tests all passed with the latest fixes. Thanks! |
|
For sure @ppt-adsk , that's done now. |
|
O.K., still more fixes required on our end to solve Linux interactive tests, but you're good to go. Will be merged when we resume merging after the next maya-usd release. |
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added consideration of offset parent matrix being part of the 'local space matrix' of a Maya node, since it's only needed for anim cache, note that there is no round-tripping support to/from Maya <-> USD.