-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAYA-122362 cache-to-USD file type persistence #2316
Merged
seando-adsk
merged 6 commits into
dev
from
t_bailp/MAYA-122362/cache-file-type-persistence
May 10, 2022
Merged
MAYA-122362 cache-to-USD file type persistence #2316
seando-adsk
merged 6 commits into
dev
from
t_bailp/MAYA-122362/cache-file-type-persistence
May 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Apr 27, 2022
- Refactor functions used to create the USD file format list.
- Provide function to retrieve different USD file format labels.
- Provide functions to get and set (load and save) the last-used USD file format used during caching.
- Make all USD dialogs use the same file formats list.
The defaults were not parsed properly when a list with a single item was given as teh default as it could not determine if it was a text or floating-point values.
- Refactor functions used to create the USD file format list. - Provide function to retrieve different USD file format labels. - Provide functions to get and set (load and save) the last-used USD file format used during caching. - Make all USD dialogs use the same file formats list.
…che-file-type-persistence
@seando-adsk this PR might have gone under the radar? |
seando-adsk
requested changes
May 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a couple of minor comments
seando-adsk
approved these changes
May 3, 2022
pierrebai-adsk
added
the
ready-for-merge
Development process is finished, PR is ready for merge
label
May 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
adsk
Related to Autodesk plugin
good first issue
Good for newcomers
ready-for-merge
Development process is finished, PR is ready for merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.