Implement pivot accessors for wrapped matrix ops. #2319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Apr 28, 2022
| @@ -64,6 +64,20 @@ Ufe::Vector3d UsdTransform3dSetObjectMatrix::scale() const | |||
| return getScale(UsdTransform3dBase::matrix()); | |||
| } | |||
|
|
|||
| Ufe::Vector3d UsdTransform3dSetObjectMatrix::rotatePivot() const { return _wrapped->rotatePivot(); } | |||
There was a problem hiding this comment.
Forward pivot accessors to the wrapped Transform3d.
| @@ -228,6 +232,37 @@ def testRotatePivotCmd(self): | |||
| sphereMatrix = om.MMatrix(t3d.inclusiveMatrix().matrix) | |||
| self.checkPos(sphereMatrix, [20, 10, 0]) | |||
|
|
|||
| def testRotatePivotMatrixOp(self): | |||
There was a problem hiding this comment.
Test driven development: test written first, failed, implemented fix, test passes.
williamkrick
approved these changes
Apr 28, 2022
ppt-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the rotate or scale pivot on a prim with a matrix (a.k.a. transform) transform op immediately creates a Maya fallback matrix stack, because pivot values are not supported by the single matrix data model. When this occurs, a UsdTransform3dSetObjectMatrix wrapper Ufe::Transform3d interface is created to wrap the Maya fallback matrix stack. This wrapper did not forward the pivot accessors to the wrapped Maya fallback stack, now fixed.