Improvements to USDGeomScope Functionality #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sformType, or falls back to standard transforms if that fails (Autodesk#1013)
|
@fowlertADSK, @pilarmolinalopez - since you have done the initial USDGeomScope review, I hope you don't mind if I send this one your way too. |
fowlertADSK
approved these changes
Feb 3, 2020
| AL_MAYA_CHECK_ERROR_RETURN_NULL_MOBJECT(status, "Dag node translator: unable t/o get attributes"); | ||
| MObject to = fn.create(nodeType, parent, &status); | ||
| if (status!= MS::kSuccess) { | ||
| std::cerr << "DagNodeTranslator::createNode unable to create node of type " << nodeType << ". Create transform instead" << std::endl; |
There was a problem hiding this comment.
The only thing I’d probably change is use of std::cerr. The macros here are all using MGlobal::displayError/Warning/Info functions so maybe stick with one of those?
| if(it == m_builders.end()) | ||
| { | ||
| //If we can't find a specific translator, use the DagNodeTranslator | ||
| it = m_builders.find("dagNode"); |
There was a problem hiding this comment.
I was going to ask if we need to check if it actually found this one but it looks like it’s added in the constructor and should always be there.
pilarmolinalopez
approved these changes
Feb 3, 2020
murphyeoin
changed the title
fowlertADSK
approved these changes
Feb 4, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is internal AL#1013