LOOKDEVX-670 Improved USD type support #2364
Conversation
We added new types in Ufe 0.4.15. This updates maps them to their corresponding USD types.
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Non-Negotiable requirement. |
JGamache-autodesk
added
ufe
| T gfVec = vt.UncheckedGet<T>(); | ||
| U ret; | ||
| constexpr size_t num = ret.vector.size(); | ||
| std::copy(gfVec.data(), gfVec.data() + num, ret.vector.data()); |
There was a problem hiding this comment.
Support 2 and 4 component vectors. Still works pre-0.4.15.
|
|
||
| template <typename T, typename U> | ||
| U getUsdAttributeColorAsUfe(const PXR_NS::UsdAttribute& attr, const PXR_NS::UsdTimeCode& time) | ||
| { |
There was a problem hiding this comment.
But since we are accessing the inner class, we must create a specialization for colors because the name of the inner class is different.
test/lib/ufe/testAttribute.py
Outdated
| @@ -160,8 +176,17 @@ def runUndoRedoUsingMayaSetAttr(self, attr, newVal, decimalPlaces=None): | |||
| setAttrPath = self.getMayaAttrStr(attr) | |||
| if isinstance(newVal, (ufe.Vector3i, ufe.Vector3f, ufe.Vector3d)): | |||
| cmds.setAttr(setAttrPath, newVal.x(), newVal.y(), newVal.z()) | |||
| elif isinstance(newVal, ufe.Vector2f): | |||
There was a problem hiding this comment.
We could support all vector types with a single:
cmds.setAttr(setAttrPath, *newVal.vector)
If we want to sinplify this a little.
test/lib/ufe/testAttribute.py
Outdated
| # Pre Ufe 0.4.15: Maya might return the result as a string for colors. Fixed to always | ||
| # return a vector post 0.4.15. | ||
| if isinstance(getAttrValue, str): | ||
| getAttrValue = eval(getAttrValue) |
There was a problem hiding this comment.
Will replace with ast.literal_eval as this will work fine and be safer.
|
Ready for merge. Preflight succeeded except for one machine experiencing technical difficulties. |
JGamache-autodesk
added
the
ready-for-merge
lib/mayaUsd/ufe/UsdAttribute.h
Outdated
|
|
||
| using TypedUsdAttribute<Ufe::Matrix3d>::TypedUsdAttribute; | ||
|
|
||
| //! Create a UsdAttributeDouble3. |
There was a problem hiding this comment.
Comment should be UsdAttributeMatrix3d
There was a problem hiding this comment.
This comment does not provide any extra information. Removed since reading the function signature is sufficient.
lib/mayaUsd/ufe/UsdAttribute.h
Outdated
|
|
||
| using TypedUsdAttribute<Ufe::Matrix4d>::TypedUsdAttribute; | ||
|
|
||
| //! Create a UsdAttributeDouble4. |
There was a problem hiding this comment.
Comment should be UsdAttributeMatrix4d
We added new types in Ufe 0.4.15. This updates maps them to their
corresponding USD types.