[al] added generate unique key method for translators (#1005) #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1005) * [PIPE-1121] Added generateUniqueKey method for translators * [PIPE-1121] Changed internal unique key type to std::size_t; minor code tweaked.
| for(uint32_t j = 2; j < strings3.length(); ++j) | ||
| { | ||
| if (strings3[j].substring(0, 10) == uniqueKeyPrefix) | ||
| { | ||
| auto keyStr(strings3[j].substring(10, strings3[j].length())); |
There was a problem hiding this comment.
it may be a good idea to have 10 be defined as a variable with a descriptive name (maybe uniqueKeyPrefixLength) instead of being hardcoded twice here
| //---------------------------------------------------------------------------------------------------------------------- | ||
| void TranslatorContext::updateUniqueKeys() | ||
| { | ||
| auto stage = getUsdStage(); |
There was a problem hiding this comment.
maybe check that stage != nullptr ?
| @@ -64,25 +64,52 @@ PrimFilter::PrimFilter( | |||
| // if the type remains the same, and the type supports update | |||
| if(existingTranslatorId == newTranslatorId) | |||
| { | |||
| if(supportsUpdate) | |||
| // locate the path and delete from the removed set (we do not want to delete this prim! | |||
There was a problem hiding this comment.
close parenthesis at the end of this comment
| if (!res) { | ||
| return 0; | ||
| } | ||
| TfPyLock pyLock; |
There was a problem hiding this comment.
Sorry, I'm not very familiar with TfPyLock... are we using this lock here?
pilarmolinalopez
approved these changes
Feb 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typically when using a custom translator, the following action occurs on a variant switch:
If a prim that had previously been translated into Maya, remains in the stage after a variant switch, and that prim supports update, then the translator's update method will be called. In some cases this update step may be entirely superfluous (because none of the data changed).
For some of the translators we use internally, there are cases where the cost of updating can be very large, so this PR adds a way to optionally generate a hash for a translated prim, which can be used again later on to determine whether update should be called or not.
Within a translator, you would override the generateUniqueKey method, to return a hashed value for a specific prim.