Route visibility edits and run clang-format #2546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
requested changes
Aug 16, 2022
test/lib/ufe/testVisibilityCmd.py
Outdated
| ''' Called initially to set up the Maya test environment ''' | ||
| # Load plugins | ||
| self.assertTrue(self.pluginsLoaded) | ||
| mayaUtils.openTopLayerScene() |
There was a problem hiding this comment.
Doesn't look like this test scene is used at all, should remove this line.
There was a problem hiding this comment.
Thanks for the review and feedback! Will fix these points 👍
test/lib/ufe/testVisibilityCmd.py
Outdated
| 'over "B"\n{\n token visibility = "invisible"\n}') | ||
|
|
||
| if __name__ == '__main__': | ||
| unittest.main(verbosity=2) |
There was a problem hiding this comment.
Nit-pick: should probably add a new line here at end of file just for completeness.
ppt-adsk
approved these changes
Aug 16, 2022
|
Good work @jallex! If ready for merge, add the ready-for-merge label and we'll put it in. Cheers. |
gracekumagai
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.