MAYA-123044: As a user, I'd like to see orphaned objects' icons dimmed #2561
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Set icon disabled with Maya object is orphaned. * Added unit test for tree view cell info and icon in this orphaned case.
seando-adsk
commented
Aug 22, 2022
| Ufe::UIInfoHandler::Icon icon; | ||
| if (isOrphaned(mayaItem)) { | ||
| icon = Ufe::UIInfoHandler::Icon("", "orphaned_node_badge", Ufe::UIInfoHandler::LowerRight); | ||
| icon.mode = UIInfoHandler::Disabled; |
There was a problem hiding this comment.
Set icon disabled when orphaned.
seando-adsk
commented
Aug 22, 2022
Comment on lines
+94
to
+96
| if os.getenv('UFE_PREVIEW_VERSION_NUM', '0000') >= '4029': | ||
| # Ball_3 should have a "normal" icon mode. | ||
| self.assertEqual(ufe.UIInfoHandler.Normal, icon.mode) |
There was a problem hiding this comment.
icon mode was added to Ufe 0.4.29
ppt-adsk
previously approved these changes
Aug 23, 2022
* Added missing UFE ifdef
ppt-adsk
approved these changes
Aug 23, 2022
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-123044: As a user, I'd like to see orphaned objects' icons dimmed