Workaround for USD Issue 2013 #2569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See PixarAnimationStudios/OpenUSD#2013 I do hope to get a better workaround either in the issue comments or on this USD-interests thread: https://groups.google.com/g/usd-interest/c/5LZT-IOaOTU/m/XwLzFTq7AgAJ But, in the meantime, creating a dummy prim under the material is enough to cause the resync to happen... Feel free to revoke my coding license. This is ugly.
|
No hurry on reviewing/merging this. I do still have hope a better solution will be proposed. |
vlasovi
reviewed
Aug 29, 2022
| @@ -102,6 +102,20 @@ _GetShaderNodeDef(const PXR_NS::UsdPrim& prim, const PXR_NS::TfToken& attrName) | |||
| return registry.GetShaderNodeByIdentifier(srcInfoId); | |||
| } | |||
|
|
|||
| void _SendIssue2013NotifWorkaround(const UsdPrim& usdPrim) | |||
There was a problem hiding this comment.
I would rename this function name into _SendStrongConnectionChangeNotification
vlasovi
previously approved these changes
Aug 29, 2022
hodoulp
approved these changes
Aug 29, 2022
JGamache-autodesk
added
the
ready-for-merge
|
@JGamache-autodesk Should be this be merged, or do you still hope to have a better solution? |
|
Yes, please merge. I will keep an eye on the USD fix and add include guards as soon as we have a version with the fix. |
seando-adsk
deleted the
t_gamaj/UsdIssue2013/force_material_resync_on_connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PixarAnimationStudios/OpenUSD#2013
I do hope to get a better workaround either in the issue comments or on
this USD-interests thread:
https://groups.google.com/g/usd-interest/c/5LZT-IOaOTU/m/XwLzFTq7AgAJ
But, in the meantime, creating a dummy prim under the material is enough to
cause the resync to happen... Feel free to revoke my coding license.
This is ugly.