MAYA-125028 add layer muting serialization to the proxy shape #2580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Sep 2, 2022
•
pierrebai-adsk
commented
- Refactor common code to manage a dynamic string attribute on a Maya node.
- Refactor the load rules to use the new common dynamic attribute code.
- Add a new attribute on the proxy shape for layer muting.
- Added unit tests.
- Refactor common code to manage a dynamic string attribute on a Maya node. - Refactor the load rules to use the new common dynamic attribute code. - Add a new dynamic attribute on the proxy shape for layer muting. - Refactor the code used to save load rules to also save layer muting. - Added unit tests.
pierrebai-adsk
commented
Sep 7, 2022
pierrebai-adsk
commented
Sep 7, 2022
pierrebai-adsk
commented
Sep 7, 2022
pierrebai-adsk
commented
Sep 7, 2022
- Use a normal attribute instead of a dynamic attribute. - Use a string-array attribute to store multiple values. - Listen to the USD notifications to store the muted layers instead of in a pre-save callback.
ppt-adsk
reviewed
Oct 3, 2022
lib/mayaUsd/utils/loadRules.h
Outdated
| @@ -63,17 +63,20 @@ PXR_NS::UsdStageLoadRules createLoadRulesFromText(const MString& text); | |||
| /*! \brief verify if there is a dynamic attribute on the object for load rules. | |||
| */ | |||
| MAYAUSD_CORE_PUBLIC | |||
| bool hasLoadRulesAttribute(const MObject& obj); | |||
| bool hasLoadRulesAttribute(PXR_NS::MayaUsdProxyShapeBase& proxyShape); | |||
There was a problem hiding this comment.
If this is a query, the proxyShape argument should be a const ref.
ppt-adsk
approved these changes
Oct 3, 2022
|
Only PF failure are the two Linux interactive builds failed to launch... unrelated. |
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
removed
the
ready-for-merge
|
@pierrebai-adsk I removed the "ready to merge" label. The cot team is currently working on our Linux GPU machines trying to fix them. That is why your preflight had errors. Once the machines are fixed you'll need to re-run the preflight. Please wait to do that until I announce the machines are fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.