Change how the active 3D view is retrieved in the test #2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise, the test failed when run locally. The new method to retrieve the 3D view is more robust.
seando-adsk
reviewed
Sep 7, 2022
| @@ -69,8 +69,7 @@ def setUp(self): | |||
| cmds.refresh() | |||
|
|
|||
| # Get the viewport widget. | |||
| self._view = OMUI.M3dView() | |||
| OMUI.M3dView.getM3dViewFromModelPanel(self._panel, self._view) | |||
| self._view = OMUI.M3dView().active3dView() | |||
There was a problem hiding this comment.
What does this change? The code seems to be setting the panel to a persp view and then getting the viewport from it. Now you are using the active viewport. Is that still the one with persp camera?
There was a problem hiding this comment.
Yes, there is only on viewport open at that point. The old code would not return the correct panel when I ran it locally.
seando-adsk
approved these changes
Sep 7, 2022
seando-adsk
changed the title
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Otherwise, the test failed when run locally. The new method to retrieve the 3D view is more robust.