-
Notifications
You must be signed in to change notification settings - Fork 202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken AL_USDMaya and AL_USDTransaction builds (AL) #2598
Broken AL_USDMaya and AL_USDTransaction builds (AL) #2598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with putting this back as long it is doesn't start breaking the test again. We had test failures during our nightly test runs. Yves made some changes to fix that.
@boudrey What do you think of this change? |
I did a change to exactly remove those to fix an issue on a new OSX build machine. Commit 1659c82. So it will probably fail again if reverted. Could be related to the use of different CMake versions. |
@boudrey The preflight was run and passed on this change. The MayaUsd builds for master were done on the new OSX machines. Was the test one of those random failures, meaning it might fail in the future if we merge this change? |
If PF machine are also new machine, it should be fine, I don't think it was a random failure. I could not reproduced the issue on my Mac so I copied the CMake code from a project that was passing to the one that was failing on the new machine. I think you will have to give it a try. |
Thanks for looking into this. I can add a linux based conditional to the change if that helps. |
Hi @fabal, what was the symptom that you saw? I ran into a similar issue building today as well (we also build on linux). |
Hey @nxkb , in our case it is a very straightforward build error, reporting missing boost python symbols. As far as I can tell, no issue on our end with |
@fabal A linux conditional would be great as the problem we saw on our side was OSX only. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great thanks.
Sorry I didn't catch it earlier but one of the changes in #2456 , i.e., linking the boost python's library to the test executables, breaks our builds.
As I'm not across the reason for the removal in the first place, I reintroduce it here so we can discuss the best approach to get builds up and running.