Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken AL_USDMaya and AL_USDTransaction builds (AL) #2598

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

fabal
Copy link
Contributor

@fabal fabal commented Sep 14, 2022

Sorry I didn't catch it earlier but one of the changes in #2456 , i.e., linking the boost python's library to the test executables, breaks our builds.
As I'm not across the reason for the removal in the first place, I reintroduce it here so we can discuss the best approach to get builds up and running.

@fabal fabal changed the title Broken AL_USDTransaction builds Broken AL_USDMaya and AL_USDTransaction builds (AL) Sep 14, 2022
seando-adsk
seando-adsk previously approved these changes Sep 19, 2022
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with putting this back as long it is doesn't start breaking the test again. We had test failures during our nightly test runs. Yves made some changes to fix that.

@seando-adsk seando-adsk added build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge labels Sep 19, 2022
@seando-adsk
Copy link
Collaborator

@boudrey What do you think of this change?

@boudrey
Copy link
Contributor

boudrey commented Sep 20, 2022

I did a change to exactly remove those to fix an issue on a new OSX build machine. Commit 1659c82. So it will probably fail again if reverted. Could be related to the use of different CMake versions.

@seando-adsk seando-adsk added do-not-merge-yet Development is not finished, PR not ready for merge and removed ready-for-merge Development process is finished, PR is ready for merge labels Sep 20, 2022
@seando-adsk
Copy link
Collaborator

@boudrey The preflight was run and passed on this change. The MayaUsd builds for master were done on the new OSX machines. Was the test one of those random failures, meaning it might fail in the future if we merge this change?

@boudrey
Copy link
Contributor

boudrey commented Sep 20, 2022

If PF machine are also new machine, it should be fine, I don't think it was a random failure. I could not reproduced the issue on my Mac so I copied the CMake code from a project that was passing to the one that was failing on the new machine. I think you will have to give it a try.

@fabal
Copy link
Contributor Author

fabal commented Sep 20, 2022

Thanks for looking into this. I can add a linux based conditional to the change if that helps.

@nxkb
Copy link
Contributor

nxkb commented Sep 21, 2022

Hi @fabal, what was the symptom that you saw? I ran into a similar issue building today as well (we also build on linux).
This is basically what I was seeing: https://stackoverflow.com/questions/34143265/undefined-reference-to-symbol-pthread-createglibc-2-2-5?
I was able to solve it by using the -pthread solution... which would also be in a linux only block so the two solutions may be roughly equivalent at the end of the day. I can push my fix branch if its useful.

@fabal
Copy link
Contributor Author

fabal commented Sep 21, 2022

Hey @nxkb , in our case it is a very straightforward build error, reporting missing boost python symbols. As far as I can tell, no issue on our end with pthread though.

@seando-adsk
Copy link
Collaborator

@fabal A linux conditional would be great as the problem we saw on our side was OSX only.

Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great thanks.

@seando-adsk seando-adsk added ready-for-merge Development process is finished, PR is ready for merge and removed do-not-merge-yet Development is not finished, PR not ready for merge labels Sep 26, 2022
@seando-adsk seando-adsk merged commit f1b01fb into Autodesk:dev Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Related to building maya-usd repository ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants