Update exporters for string varnames #2601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The varname input of all UsdPrimVarReader nodes went from a Token to a String in USD 20.11. This updates the exporter to follow the convention currently in use, and allows re-using varnames with MaterialX. We also do not hardcode the output name of MaterialX nodes. We query the Sdr registry for the correct information. There are still too many hardcoded names and types in the exporter. To be fixed later.
seando-adsk
requested changes
Sep 19, 2022
Comment on lines
60
to
61
| static SdfValueTypeName _varnameType; | ||
| static bool _once = true; |
There was a problem hiding this comment.
Only class members should use leading underscore.
seando-adsk
approved these changes
Sep 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The varname input of all UsdPrimVarReader nodes went from a Token to a String in USD 20.11. This updates the exporter to follow the convention currently in use, and allows re-using varnames with MaterialX.
We also do not hardcode the output name of MaterialX nodes. We query the Sdr registry for the correct information.
There are still too many hardcoded names and types in the exporter. To be fixed later.