Disable edit as Maya for materials. #2631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Sep 27, 2022
| } | ||
|
|
||
| /* virtual */ | ||
| bool MaterialUpdater::canEditAsMaya() const { return false; } |
There was a problem hiding this comment.
This is the single important line of this pull request: disabling edit as Maya for materials, as per design's request. Perhaps we will find a workflow that will allow this in the future, but for now edit as Maya on a material does nothing and produces a warning.
| @@ -65,7 +64,6 @@ def tearDownClass(cls): | |||
| def setUp(self): | |||
| cmds.file(new=True, force=True) | |||
|
|
|||
| @unittest.skipUnless(ufeFeatureSetVersion() >= 3, 'Test only available in UFE v3 or greater.') | |||
There was a problem hiding this comment.
The CMakeLists.txt file explicitly adds this test file only for UFE v3, so further checking in the test is redundant.
JGamache-autodesk
approved these changes
Sep 28, 2022
ppt-adsk
added
the
ready-for-merge
seando-adsk
deleted the
tremblp/MAYA-123848/prevent_usdShade_editAsMaya
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.