Added test for getAllStages() versus delete. #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppt-adsk
commented
Oct 12, 2022
| @@ -236,6 +249,7 @@ void wrapUtils() | |||
| // representation of Ufe::Path as comma-separated segments. We know that | |||
| // the USD path separator is '/'. PPT, 8-Dec-2019. | |||
| def("getStage", getStage); | |||
| def("getAllStages", getAllStages, return_value_policy<PXR_NS::TfPySequenceToList>()); | |||
There was a problem hiding this comment.
Return value policy from example Pixar USD code, e.g.
https://github.com/PixarAnimationStudios/USD/blob/dc710925675f7f58f7a37f6c18d046a687b09271/pxr/usd/usd/wrapStageCache.cpp#L63
otherwise Boost Python complains at run-time that there is no converter for a vector of stages.
pierrebai-adsk
previously approved these changes
Oct 13, 2022
pierrebai-adsk
approved these changes
Oct 13, 2022
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MAYA-111420 was entered to ensure that getAllStages() would not return stages whose proxy shape was deleted. This bug was fixed by previous code, so simply added a test to demonstrate the fix, with undo and redo.