MAYA-125895 transfer state from root layer when toggling shareable stage #2691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we reproduce the FPS (frames-per-second) of the shared root layer to the newly-created unshared root layer so that the animation playback speed stays consistent. Y
vlasovi
reviewed
Oct 31, 2022
SdfLayer has functions to check if a FPS has been set and to get/set a FPS. Use these functions. Also check if the given input layer and stage pointers are null.
vlasovi
approved these changes
Oct 31, 2022
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we reproduce the FPS (frames-per-second) of the shared root layer to the
newly-created unshared root layer so that the animation playback speed stays consistent.