[al] import primvars as colour sets (#1029) #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 11, 2020 17:28
…sure we only generate colour sets for primvars tagged with a 'Color' role
HamedSabri-adsk
approved these changes
Feb 11, 2020
There was a problem hiding this comment.
Thanks @robthebloke . LGTM!
Would be nice if you can add a sample file perhaps under plugin/al/samples that we could share with QA.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the file import for AL_USDMaya would blindly create any float3/float4 primvar as a colour set. This would mean that any other vector based primvar (e.g. tangents/binormals) would end up being imported as colours.
This PR changes the exported colour set type to be Color3f/Color4f, and also checks the primvar role to see if the primvar is a Color type. If it is, it will be treated as a colour set.