Fixes an issue on layer editor when trying to save a root layer directly (by right clicking on the layer and Save As.), where an invalid extension could cause a crash. The fallback is .usd. #2847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tly (by right clicking on the layer and Save As.), where an invalid extension could cause a crash. The fallback is .usd. It also blocks the path that will result in the crash for any other scenario where the file cannot be opened after it was exported. The user is then displayed a message dialog indicating the layer saving was not successful.
…r-save-crashfix # Conflicts: # lib/usd/ui/layerEditor/layerTreeItem.cpp
pierrebai-adsk
requested changes
Jan 26, 2023
pierrebai-adsk
previously approved these changes
Jan 26, 2023
vlasovi
reviewed
Jan 26, 2023
| @@ -10,6 +10,7 @@ | |||
| #include "warningDialogs.h" | |||
|
|
|||
| #include <mayaUsd/base/tokens.h> | |||
| #include <mayaUsd/fileio/jobs/jobArgs.h> | |||
There was a problem hiding this comment.
Is this include necessary?
There was a problem hiding this comment.
This is no longer necessary as the function now lives in utilSerialization. I'll remove it.
vlasovi
previously approved these changes
Jan 26, 2023
AramAzhari-adsk
dismissed stale reviews from vlasovi and pierrebai-adsk
via
2592f5c
vlasovi
approved these changes
Jan 26, 2023
vlasovi
approved these changes
Jan 26, 2023
seando-adsk
approved these changes
Jan 26, 2023
AramAzhari-adsk
added
the
ready-for-merge
seando-adsk
deleted the
azharia/MAYA-127327/usd-layer-editor-rootlayer-save-crashfix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue on layer editor when trying to save a root layer directly (by right clicking on the layer and Save As.), where an invalid extension could cause a crash. The fallback is .usd.
It also blocks the path that will result in the crash for any other scenario where the file cannot be opened after it was exported. The user is then displayed a message dialog indicating the layer saving was not successful.
Similar PR: #2845