Adding a MaterialX v1.38.5 update for closures #2858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shading graphs containing closures would fail to work with MaterialX 1.38.5.
frohnej-adsk
previously approved these changes
Feb 1, 2023
lib/mayaUsd/render/MaterialXGenOgsXml/GlslFragmentGenerator.cpp
Outdated
Show resolved
Hide resolved
seando-adsk
previously approved these changes
Feb 1, 2023
JGamache-autodesk
added
the
ready-for-merge
JGamache-autodesk
dismissed stale reviews from seando-adsk and frohnej-adsk
via
4807c77
JGamache-autodesk
added
ready-for-merge
|
@seando Ready for merge when they reopen. |
seando-adsk
approved these changes
Feb 1, 2023
frohnej-adsk
approved these changes
Feb 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shading graphs containing closures would fail to work with MaterialX 1.38.5.