-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Releases the memory a data handle is holding onto when exporting meshes. #2882
Releases the memory a data handle is holding onto when exporting meshes. #2882
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also search thru the maya-usd repo and make sure there are no other uses asMDataHandle()
@seando-adsk
maya-usd/lib/usd/translators/meshWriter.cpp Line 572 in 97f96aa
Should we check them in as part of the current jira ? |
removed the extra copy statement Co-authored-by: Sean Donnelly <23455376+seando-adsk@users.noreply.github.com>
When exporting the entire scene, a data handle is used to create objects for writing meshes. When the user tries to export all again, the previous handle is not cleaned up and this results in a memory leak. The fix is to destruct the handle after use so that the memory does not increase after repetition.