MAYA-114188 save the target layer #2884
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Feb 16, 2023
pierrebai-adsk
commented
- When saving a Maya scene, the current target layer of USD stage get saved in an attribute on the proxy shape.
- When loading a scene, when creating the USD stage, set the target layer to the one that was saved.
- The target layer is persisted as a text attribute containing the USD layer identifier.
- Listen to edit target change to save the attribute when the target is set to avoid losing it if the proxy shape gets recomputed.
- Add a unit test,
- When saving a Maya scene, the current target layer of USD stage get saved in an attribute on the proxy shape. - When loading a scene, when creating the USD stage, set the target layer to the one that was saved. - The target layer is persisted as a text attribute containing the USD layer identifier. - Add a unit test,. - Listen to edit target change to save the attribute when the target is set to avoid losing it if the proxy shape gets recomputed.
pierrebai-adsk
added
enhancement
|
Only failure is testUsdExportPackage detecting undeletable files in temp. Why are we even checking the content of temp in that test? It keeps randomly failing due to that. |
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.