Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-127484 : Deleting a connected compound attribute does not delete its connection. #2894

Conversation

alicedegirolamo
Copy link
Collaborator

Description

This PR solves Jira MAYA-127484: when we delete a connected compound attribute we also have to delete the connections to/from its children and its parent, we should also check and delete (if necessary) the source and destination properties.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

We have updated the testAttributes.py in order to test more cases for deleted connections and properties.

Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks okay with me. I'm not very familiar with this code so I'll defer to Jerry for the review.

@alicedegirolamo alicedegirolamo added the ready-for-merge Development process is finished, PR is ready for merge label Feb 23, 2023
@seando-adsk seando-adsk added the ufe-usd Related to UFE-USD plugin in Maya-Usd label Feb 23, 2023
@seando-adsk seando-adsk merged commit 929877c into dev Feb 23, 2023
@seando-adsk seando-adsk deleted the degiroa/MAYA-127484/delete-compound-attribute-and-its-connections branch February 23, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-for-merge Development process is finished, PR is ready for merge ufe-usd Related to UFE-USD plugin in Maya-Usd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants