MAYA-127737 allow loading relative sub layers #2902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Feb 24, 2023
pierrebai-adsk
commented
- Add UI to load-layer file dialog to make the file path relative, in MEL.
- Modify the overall load-layer dialog to support relative sub-layers.
- Add UI to load-layer file dialog to make teh file path relative, in MEL. - Modify the overall load-layer dialog to support relative sub-layers.
pierrebai-adsk
changed the base branch from
dev
to
bailp/MAYA-127404/save-relative-sub-layers
Base automatically changed from
bailp/MAYA-127404/save-relative-sub-layers
to
dev
March 9, 2023 13:31
pierrebai-adsk
added
enhancement
seando-adsk
previously approved these changes
Mar 13, 2023
Comment on lines
+305
to
+307
| for (std::string& fileName : files) { | ||
| fileName = getPathRelativeToLayerFile(fileName, parentLayer); | ||
| } |
There was a problem hiding this comment.
It wasn't immediately obvious to me here that you were replacing the paths in the files array with relative paths. Maybe add a comment saying that is what is happening.
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
approved these changes
Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.