MAYA-127427 fix rename when staged multiple times #2904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pierrebai-adsk
commented
Feb 27, 2023
pierrebai-adsk
commented
- Protect UsdSceneItem against invalid prims.
- Protect USD UI info handler against invalid prims.
- These can happen for example when we're in the middle of a rename and the outliner gets updated or redrawn.
- Fix the rename command to send rename notifications to all proxy shape that share the same stage.
- At the same time, refactor the redo/undo code that was 99% identical.
- Protect UsdSceneItem against invalid prims. - Protect USD UI info handler against invalid prims. - These can happen for example when we're in the middle of a rename and the outliner gets updated or redrawn. - Fix the rename command to send rename notifications to all proxy shape that share the same stage. - At the same time, refactor the redo/undo code that was 99% identical.
pierrebai-adsk
added
bug
The prim can be stale when a rename is in the middle of a composite command. For example, the assign-material command.
AramAzhari-adsk
approved these changes
Feb 28, 2023
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.