MAYA-103572 Disable a couple warnings #293
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… headers. Avoids "warning treated as errors" in a couple specific cases.
|
This was causing compilation errors on Windows with Maya 2018 and 2019 (#279 #233). |
robthebloke
reviewed
Feb 24, 2020
| #include <boost/thread.hpp> | ||
| #ifdef _MSC_VER | ||
| #pragma warning( pop ) | ||
| #endif |
There was a problem hiding this comment.
No real problem against doing this. If this happens on a frequent occurrence, then a macro such as:
#define PUSH_DISABLE_WARNING_MSVC4002 \
__pragma(warning(push)) \
__pragma(warning(disable:4002))
#define PUSH_DISABLE_WARNING_MSVC4275 \
__pragma(warning(push)) \
__pragma(warning(disable:4275))
#define POP_DISABLE_WARNINGS \
__pragma(warning(pop)) Might be an idea, but no real issue with this as is.
robthebloke
approved these changes
Feb 24, 2020
ppt-adsk
pushed a commit
that referenced
this pull request
Feb 28, 2023
…code and remove hydra errors at startup. (#293)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable a couple warnings before including a couple boost headers. Avoids "warning treated as errors" in a couple specific cases.