A piece of PR183 - approximate equality checks #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e pieces. This piece has the part that everyone agreed was safe to merge in - approximate equality checks of new values against currently set values to determine whether or not new values need to be saved.
|
Added @elrond79 and @murphyeoin as reviewers since they were providing feedback on #183 |
pmolodo
approved these changes
Feb 21, 2020
| @@ -1119,6 +1119,7 @@ void TransformationMatrix::initialiseToPrim(bool readFromPrim, Scope* transformN | |||
| MPlug(transformNode->thisMObject(), MPxTransform::shearXZ).setValue(tempShear.y); | |||
| MPlug(transformNode->thisMObject(), MPxTransform::shearYZ).setValue(tempShear.z); | |||
| m_shearTweak[0] = m_shearTweak[1] = m_shearTweak[2] = 0; | |||
| m_shearFromUsd = tempShear; | |||
There was a problem hiding this comment.
Ideally, this would be on it's own PR or at least commit - both because it's obviously different than the rest of the changes, and because it seems like an important enough bug fix to deserve splitting out.
Having said that - this does seem like a needed fix, and you've already been good enough to split things out into two separate commits, so I'm not going to hold things up over this.
robthebloke
approved these changes
Feb 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the full pr/animationMissingAfterMayaFileSaveReopen was too controversial, breaking out some pieces. This piece has the part that everyone agreed was safe to merge in - approximate equality checks of new values against currently set values to determine whether or not new values need to be saved. Plus a couple of changes that address what looked like small oversights.
(This change alone fixes the problem where we bring in a usd file with a sphere, turn on the Move To manipulator, and then, via python calls, select the sphere, set the sphere's rotateZ to 45 degrees, unselect the sphere, reselect the sphere and the rotation (and usd "over" that sets it) is inexplicably reset to 0,0,0.)