Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added applyEulerFilter to import #2942

Merged
merged 6 commits into from
Mar 30, 2023

Conversation

tryptik
Copy link

@tryptik tryptik commented Mar 15, 2023

It has proven useful to allow the Euler filtering of rotational animation on import as well as export. This P/R adds a flag aef/applyEulerFilter flag to mayaUSDImport that applies Euler filtering for transform and skeletal animation data.

Clang-format

Updated skeletal import

Updated copyright
@seando-adsk seando-adsk added the import-export Related to Import and/or Export label Mar 15, 2023
pierrebai-adsk
pierrebai-adsk previously approved these changes Mar 15, 2023
Copy link
Collaborator

@pierrebai-adsk pierrebai-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work

pierrebai-adsk
pierrebai-adsk previously approved these changes Mar 20, 2023
@seando-adsk
Copy link
Collaborator

@tryptik Unfortunately the clang-format step (of the preflight) failed. Can you please make the changes and I'll re-run the preflight again.

@tryptik
Copy link
Author

tryptik commented Mar 23, 2023

I have run the clang formatter and removed some older code fragments from a previous implementation.

pierrebai-adsk
pierrebai-adsk previously approved these changes Mar 23, 2023
@seando-adsk
Copy link
Collaborator

@tryptik Unfortunately the clang-format step failed again. If you are running it locally make sure you are using v10.0.0.

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Mar 30, 2023
@seando-adsk seando-adsk merged commit 0b7a959 into Autodesk:dev Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
import-export Related to Import and/or Export ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants