Check skin cluster weights #2971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seando-adsk
reviewed
Mar 27, 2023
Comment on lines
241
to
246
| MString msg("Number of weights ("); | ||
| msg += weights.length(); | ||
| msg += ") exceeds number of influences * number of vertices ("; | ||
| msg += numInfluences * numVertices; | ||
| msg += ") - skin binding will not be written"; | ||
| MGlobal::displayError(msg); |
There was a problem hiding this comment.
Would it be possible to add to this message a way to fix the problem or a workaround for problem?
tryptik
force-pushed
the
check_skinCluster_weights
branch
from
98db0ca to
df83033
Compare
|
I've updated the error message, added code that checks to see if |
seando-adsk
approved these changes
Apr 6, 2023
seando-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an artist uses polyReduce (or other node that changes the vertex count) after a skinCluster has been applied, the Usd exporter tries to compare the weights of the original vertex count with the assigned weights of the reduced vertex count. This results in an out-of-bounds access to the MDoubleArray that holds the weights.
This P/R checks for that condition and throws an exception if encountered (this occurs in a part of the plugin that is not using
MStatusto signal success/failure/error).