MAYA-128779 - Improvements for surface shader querying and handling #3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gz-adsk
force-pushed
the
gz-adsk/MAYA-128779/surface-shader-querying-and-handling
branch
from
d056126 to
ded6ad2
Compare
- Utility function UsdMayaUtil::GetSurfaceShaderNodeDefs() for getting vetted surfaces as well as those with "shader/surface" role (adds afew arnold ones, potentially more) - UsdShaderNodeDef::definitions can now be queried for surface definitions only in order to access them through UFE - UsdShaderNodeDef::createNodeCmd will implicitly create a material if given a valid material scope - UsdUndoAddNewMaterialCommand will only attempt to connect surface nodes to material output - UI specific string requirements have been pushed to UsdMayaUtil::prettifyName for consistency
gz-adsk
force-pushed
the
gz-adsk/MAYA-128779/surface-shader-querying-and-handling
branch
from
ded6ad2 to
5a2e1dc
Compare
frohnej-adsk
approved these changes
Apr 6, 2023
| == UsdUndoAssignNewMaterialCommand::resolvedMaterialScopeName()) { | ||
| return UsdUndoAddNewMaterialCommand::create( | ||
| parentItem, fShaderNodeDef->GetIdentifier()); | ||
| } |
There was a problem hiding this comment.
[Note] This implicit material creation can probably be removed again in the future. There is a UFE interface for material creation in the works and once it's done, it should be able to take care of this.
JGamache-autodesk
approved these changes
Apr 11, 2023
vlasovi
approved these changes
Apr 11, 2023
gz-adsk
added
ufe-usd
seando-adsk
deleted the
gz-adsk/MAYA-128779/surface-shader-querying-and-handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UsdMayaUtil::GetSurfaceShaderNodeDefs()for getting vetted surfaces as well as those with "shader/surface" role (adds afew arnold ones, potentially more)UsdShaderNodeDef::definitionscan now be queried for surface definitions only in order to access them through UFEUsdShaderNodeDef::createNodeCmdwill implicitly create a material if given a valid material scopeUsdUndoAddNewMaterialCommandwill only attempt to connect surface nodes to material outputUsdMayaUtil::prettifyNamefor consistency