Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove/replace all UFE_PREVIEW_VERSION_NUM #3020

Merged
merged 6 commits into from
Apr 25, 2023

Conversation

samuelliu-adsk
Copy link
Collaborator

Remove/replace all UFE_PREVIEW_VERSION_NUM for that latest Maya has UFE v4

@samuelliu-adsk samuelliu-adsk added adsk Related to Autodesk plugin ufe Related to UFE component in Maya labels Apr 13, 2023
@samuelliu-adsk samuelliu-adsk force-pushed the samuelliu-adsk/MAYA-128570/update_ufe_preview_checks branch from 2fab034 to 465f86b Compare April 13, 2023 02:01
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thanks. Just a few minor things to fixup.
Can you also add Maya 2023 at 132 here: https://github.com/Autodesk/maya-usd/blob/dev/test/testUtils/mayaUtils.py#L281

lib/mayaUsd/ufe/Global.cpp Outdated Show resolved Hide resolved
lib/mayaUsd/ufe/StagesSubject.cpp Outdated Show resolved Hide resolved
lib/mayaUsd/ufe/UsdConnectionHandler.cpp Outdated Show resolved Hide resolved
lib/mayaUsd/ufe/UsdShaderNodeDef.h Outdated Show resolved Hide resolved
lib/mayaUsd/ufe/UsdHierarchy.h Outdated Show resolved Hide resolved
lib/mayaUsd/ufe/Utils.cpp Show resolved Hide resolved
lib/mayaUsd/ufe/Utils.cpp Show resolved Hide resolved
lib/mayaUsd/ufe/Utils.cpp Show resolved Hide resolved
test/lib/ufe/testShaderNodeDef.py Outdated Show resolved Hide resolved
seando-adsk
seando-adsk previously approved these changes Apr 18, 2023
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good. Thanks.

@samuelliu-adsk samuelliu-adsk added ready-for-merge Development process is finished, PR is ready for merge and removed ready-for-merge Development process is finished, PR is ready for merge labels Apr 18, 2023
@samuelliu-adsk samuelliu-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Apr 20, 2023
@seando-adsk seando-adsk removed the ready-for-merge Development process is finished, PR is ready for merge label Apr 21, 2023
@samuelliu-adsk samuelliu-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Apr 24, 2023
@samuelliu-adsk
Copy link
Collaborator Author

Build tested internally #905

@seando-adsk seando-adsk merged commit 0eba2ee into dev Apr 25, 2023
@seando-adsk seando-adsk deleted the samuelliu-adsk/MAYA-128570/update_ufe_preview_checks branch April 25, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adsk Related to Autodesk plugin ready-for-merge Development process is finished, PR is ready for merge ufe Related to UFE component in Maya
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants