Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate mtoh .mod file. #3038

Merged
merged 3 commits into from
Apr 27, 2023
Merged

Separate mtoh .mod file. #3038

merged 3 commits into from
Apr 27, 2023

Conversation

ppt-adsk
Copy link
Collaborator

@ppt-adsk ppt-adsk commented Apr 26, 2023

mtoh part of .mod file split into a separate mtoh.mod, which is installed only if mtoh is enabled in the build.

@ppt-adsk ppt-adsk requested a review from seando-adsk April 26, 2023 18:38
@ppt-adsk ppt-adsk added the mtoh Related to legacy Maya to Hydra plugin. label Apr 26, 2023
seando-adsk
seando-adsk previously approved these changes Apr 26, 2023
Copy link
Collaborator

@seando-adsk seando-adsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although technically we didn't need a separate windows mod file since MtoH doesn't change PATH.

@ppt-adsk
Copy link
Collaborator Author

Should I remove the Windows-specific .mod file then? Don't want to add dead code.

@seando-adsk seando-adsk added the ready-for-merge Development process is finished, PR is ready for merge label Apr 27, 2023
@seando-adsk seando-adsk merged commit 38b8fc9 into dev Apr 27, 2023
@seando-adsk seando-adsk deleted the tremblp/HYDRA-290/mtoh_mod branch April 27, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mtoh Related to legacy Maya to Hydra plugin. ready-for-merge Development process is finished, PR is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants