Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAYA-103409 Minimal Create USD Stage #306

Merged
merged 2 commits into from
Feb 27, 2020

Conversation

luceric-adsk
Copy link
Collaborator

@luceric-adsk luceric-adsk commented Feb 25, 2020

A user currently can't create a USD stage using the UI. This UI will allow the user to create a stage using an existing USD layer.

In Maya's top level menu, under Create, a new entry 'Universal Scene Description (USD)' is underneath 'Scene Management' category. Please have this in the What's New green highlight style. On hover, the submenu appears with the following entry:
"Stage from Existing Layer..."
Please have this in the What's New green highlight style. On click, the following file dialogue appears[...]

Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly looks good, but I think we want to make sure that the new loadPayloads attribute is enabled by default to preserve existing behavior.

"loadPayloads",
"lpl",
MFnNumericData::kBoolean,
0.0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this attribute be turned on by default? That would preserve existing behavior of loading payloads when opening the stage.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point, but it does default to 'true', there is setDefault(true) call a couple of lines below. Maybe I should not have been so clever

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me fix that by doing in the definition line instead

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, sorry! I read right past that setDefault(true) call.

But yeah, looks a bit cleaner to just have it in the initial definition. Thanks!

@luceric-adsk
Copy link
Collaborator Author

added support for case when user is using native dialog

Copy link
Contributor

@mattyjams mattyjams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@kxl-adsk kxl-adsk merged commit a1b125a into dev Feb 27, 2020
@kxl-adsk kxl-adsk deleted the roussel/MAYA-103409/Minimal_Create_USD_Stage branch February 27, 2020 23:01
ppt-adsk pushed a commit that referenced this pull request Feb 28, 2023
* MAYA-126057 : Fix various bugs related to lighting / shadowing

* MAYA-126057 : fix a problem of wireframe prims not being shown when switching back and forth to enable/disable lighting.

* MAYA-126057 : Re-enable the nodeadded callback to handle the lights being added to the scene.

* MAYA-126057 : Filter lights in the node added callback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants