MAYA-129169 improve the behavior of duplication vs payload #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handling all possible scenarios is potentially impossible given that our Maya-level view are of fully composed prims. So when Maya requests to duplicate a prim, we get a simple request to duplicate whatever is at a given UFE path. In USD, that could be in the stage, in a payload, in a reference or a combination of these. Plus, given composed opinions from multiple layers, it could be a complex combination. This change slightly improve the behaviour to handle some simple the cases. - Add heuristics to try to do the right thing when payloads are involved. - Make sure to always at least keep the defining layer, in case the heuristic thinks it should be rejected. - Added a unit test for duplicate with payload.
AramAzhari-adsk
approved these changes
May 5, 2023
|
PF #959, only failure is the known image comparison test failure in Windows 2020 |
pierrebai-adsk
added
the
ready-for-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handling all possible scenarios is potentially impossible given that our Maya-level view are of fully composed prims. So when Maya requests to duplicate a prim, we get a simple request to duplicate whatever is at a given UFE path. In USD, that could be in the stage, in a payload, in a reference or a combination of these. Plus, given composed opinions from multiple layers, it could be a complex combination.
This change slightly improve the behaviour to handle some simple the cases.