MAYA-129169 correctly duplicate prim #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Correctly handle all these case: - Simple prim with a single opinion: simple copy of source layer into destination layer. - Prim with opinion in multiple local layers: marge all opinion in destination layer. - Prim containing a USD reference: keep the reference but do not copy the reference contents into the destination layer. - Prim containing a USD payload: keep the payload but do not copy the payload contents into the destination layer. - Prim inside a reference or payload: copy the reference or payload contents in the destination layer. The code changes are: - Move layer-related function from the geneic util.h header and C++ file to the more specific utils/layers.h header and C++ file. - Make the getLocalPrimStack function available publicly. - Add getPrimStackForLayers function to find where a prim has opinions in a setof layers. - Add a description for the USD implementation of the UFE duplicate command. - It explains that the command copies the local opinions of the prim where it is defined. - Add a unit test that verify that duplicating a prim containing a USD reference does not copy the contents of the reference in the copy. - Remove the LayerAndPath type and replace it with PrimSpecHandle. - Prim spec contain the necessary data, and more, so it is more versatile. - Change some function names to be clearer.
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
reviewed
May 11, 2023
| @@ -32,6 +32,17 @@ namespace MAYAUSD_NS_DEF { | |||
| namespace ufe { | |||
|
|
|||
| //! \brief UsdUndoDuplicateCommand | |||
| //! | |||
| //! \details The USD duplicate command copies all opinions related the the USD prim | |||
There was a problem hiding this comment.
small typo -> double "the"
There was a problem hiding this comment.
I'm okay if you fix this in a follow-up PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly handle all these case:
The code changes are: