MAYA-128939 remove error message on deleting a stage #3093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error was printed from a utility function to map from a DAG object to a USD stage. Utility functions should not warn, the caller should warn if it realyl thinks it is an error. Here, we are responding to a notification sent in the middle of DAG object deletion, so it is expected that the object is not valid. This shows that printing an error in this case is incorrect.
pierrebai-adsk
added
bug
AramAzhari-adsk
approved these changes
May 15, 2023
pierrebai-adsk
added
the
ready-for-merge
seando-adsk
added
ufe-usd
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error was printed from a utility function to map from a DAG object to a USD stage. Utility functions should not warn, the caller should warn if it realyl thinks it is an error. Here, we are responding to a notification sent in the middle of DAG object deletion, so it is expected that the object is not valid. This shows that printing an error in this case is incorrect.